Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bastion sku configuration #4383

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add bastion sku configuration #4383

wants to merge 6 commits into from

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Feb 19, 2025

Fixes #86

Add a variable to configure Azure Bastion SKU and default to Developer (free).

  • Add bastion_sku variable to config.sample.yaml with default value Developer.
  • Add conditional logic in core/terraform/bastion.tf to deploy Azure Bastion based on bastion_sku variable.
  • Update azurerm_bastion_host resource in core/terraform/bastion.tf to use bastion_sku variable.
  • Add bastion_sku variable to core/terraform/variables.tf with default value Developer.
  • Add bastion_sku variable to config_schema.json.
  • Document the new bastion_sku variable in docs/tre-admins/environment-variables.md.

For more details, open the Copilot Workspace session.

Fixes #86

Add a variable to configure Azure Bastion SKU and default to Developer (free).

* Add `bastion_sku` variable to `config.sample.yaml` with default value `Developer`.
* Add conditional logic in `core/terraform/bastion.tf` to deploy Azure Bastion based on `bastion_sku` variable.
* Update `azurerm_bastion_host` resource in `core/terraform/bastion.tf` to use `bastion_sku` variable.
* Add `bastion_sku` variable to `core/terraform/variables.tf` with default value `Developer`.
* Add `bastion_sku` variable to `config_schema.json`.
* Document the new `bastion_sku` variable in `docs/tre-admins/environment-variables.md`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/86?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

github-actions bot commented Feb 19, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit fe098ad.

♻️ This comment has been updated with latest results.

* Update `config.sample.yaml` to include `bastion_sku` variable with default value `Developer`
* Update `docs/tre-admins/environment-variables.md` to document the new `bastion_sku` variable and its allowed values
@marrobi
Copy link
Member Author

marrobi commented Feb 19, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13418035949 (with refid edf3a526)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Feb 19, 2025

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/13418661236 (with refid edf3a526)

(in response to this comment from @marrobi)

@marrobi marrobi marked this pull request as draft February 19, 2025 20:26
@marrobi
Copy link
Member Author

marrobi commented Feb 19, 2025

Switching to draft given limited region availability.

@marrobi
Copy link
Member Author

marrobi commented Feb 19, 2025

/test-destroy-env

Copy link

Destroying branch test environment (RG: rg-tre99b35af5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13421727493)

Copy link

Branch test environment destroy complete (RG: rg-tre99b35af5)

Copy link

Destroying PR test environment (RG: rg-treedf3a526)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13421727493)

Copy link

PR test environment destroy complete (RG: rg-treedf3a526)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Azure bastion free sku.
1 participant